I think the dremio-oss Glue endpoint for China regions is not correct

zorrofox · October 12, 2022, 9:55am

I found there have some issues in the code base:

dremio/dremio-oss/blob/398ead8918dc1dd7c2c1e8c4d4e4ba53d78f3fed/sabot/kernel/src/main/java/com/dremio/exec/catalog/conf/AWSRegionSelection.java#L37


      
          @Tag(4) @DisplayMetadata(label = "US West (Oregon) us-west-2") US_WEST_2("us-west-2"),
          @Tag(5) @DisplayMetadata(label = "Africa (Cape Town) af-south-1") AF_SOUTH_1("af-south-1"),
          @Tag(6) @DisplayMetadata(label = "Asia Pacific (Hong Kong) ap-east-1") AP_EAST_1("ap-east-1"),
          @Tag(7) @DisplayMetadata(label = "Asia Pacific (Mumbai) ap-south-1") AP_SOUTH_1("ap-south-1"),
          @Tag(8) @DisplayMetadata(label = "Asia Pacific (Osaka-Local) ap-northeast-3") AP_NORTHEAST_3("ap-northeast-3"),
          @Tag(9) @DisplayMetadata(label = "Asia Pacific (Seoul) ap-northeast-2") AP_NORTHEAST_2("ap-northeast-2"),
          @Tag(10) @DisplayMetadata(label = "Asia Pacific (Singapore) ap-southeast-1") AP_SOUTHEAST_1("ap-southeast-1"),
          @Tag(11) @DisplayMetadata(label = "Asia Pacific (Sydney) ap-southeast-2") AP_SOUTHEAST_2("ap-southeast-2"),
          @Tag(12) @DisplayMetadata(label = "Asia Pacific (Tokyo) ap-northeast-1") AP_NORTHEAST_1("ap-northeast-1"),
          @Tag(13) @DisplayMetadata(label = "Canada (Central) ca-central-1") CA_CENTRAL_1("ca-central-1"),
          @Tag(14) @DisplayMetadata(label = "China (Beijing) ca-north-1") CA_NORTH_1("ca-north-1"),
          @Tag(15) @DisplayMetadata(label = "China (Ningxia) ca-northwest-1") CA_NORTHWEST_1("ca-northwest-1"),
          @Tag(16) @DisplayMetadata(label = "Europe (Frankfurt) eu-central-1") EU_CENTRAL_1("eu-central-1"),
          @Tag(17) @DisplayMetadata(label = "Europe (Ireland) eu-west-1") EU_WEST_1("eu-west-1"),
          @Tag(18) @DisplayMetadata(label = "Europe (London) eu-west-2") EU_WEST_2("eu-west-2"),
          @Tag(19) @DisplayMetadata(label = "Europe (Milan) eu-south-1") EU_SOUTH_1("eu-south-1"),
          @Tag(20) @DisplayMetadata(label = "Europe (Paris) eu-west-3") EU_WEST_3("eu-west-3"),
          @Tag(21) @DisplayMetadata(label = "Europe (Stockholm) eu-north-1") EU_NORTH_1("eu-north-1"),
          @Tag(22) @DisplayMetadata(label = "Middle East (Bahrain) me-south-1") ME_SOUTH_1("me-south-1"),
          @Tag(23) @DisplayMetadata(label = "South America (São Paulo) sa-east-1") SA_EAST_1("sa-east-1"),
          @Tag(24) @DisplayMetadata(label = "AWS GovCloud (US-East) us-gov-east-1") US_GOV_EAST_1("us-gov-east-1"),

and

github.com

dremio/dremio-oss/blob/398ead8918dc1dd7c2c1e8c4d4e4ba53d78f3fed/sabot/kernel/src/main/java/com/dremio/exec/catalog/conf/AWSRegionSelection.java#L38


      
          @Tag(5) @DisplayMetadata(label = "Africa (Cape Town) af-south-1") AF_SOUTH_1("af-south-1"),
          @Tag(6) @DisplayMetadata(label = "Asia Pacific (Hong Kong) ap-east-1") AP_EAST_1("ap-east-1"),
          @Tag(7) @DisplayMetadata(label = "Asia Pacific (Mumbai) ap-south-1") AP_SOUTH_1("ap-south-1"),
          @Tag(8) @DisplayMetadata(label = "Asia Pacific (Osaka-Local) ap-northeast-3") AP_NORTHEAST_3("ap-northeast-3"),
          @Tag(9) @DisplayMetadata(label = "Asia Pacific (Seoul) ap-northeast-2") AP_NORTHEAST_2("ap-northeast-2"),
          @Tag(10) @DisplayMetadata(label = "Asia Pacific (Singapore) ap-southeast-1") AP_SOUTHEAST_1("ap-southeast-1"),
          @Tag(11) @DisplayMetadata(label = "Asia Pacific (Sydney) ap-southeast-2") AP_SOUTHEAST_2("ap-southeast-2"),
          @Tag(12) @DisplayMetadata(label = "Asia Pacific (Tokyo) ap-northeast-1") AP_NORTHEAST_1("ap-northeast-1"),
          @Tag(13) @DisplayMetadata(label = "Canada (Central) ca-central-1") CA_CENTRAL_1("ca-central-1"),
          @Tag(14) @DisplayMetadata(label = "China (Beijing) ca-north-1") CA_NORTH_1("ca-north-1"),
          @Tag(15) @DisplayMetadata(label = "China (Ningxia) ca-northwest-1") CA_NORTHWEST_1("ca-northwest-1"),
          @Tag(16) @DisplayMetadata(label = "Europe (Frankfurt) eu-central-1") EU_CENTRAL_1("eu-central-1"),
          @Tag(17) @DisplayMetadata(label = "Europe (Ireland) eu-west-1") EU_WEST_1("eu-west-1"),
          @Tag(18) @DisplayMetadata(label = "Europe (London) eu-west-2") EU_WEST_2("eu-west-2"),
          @Tag(19) @DisplayMetadata(label = "Europe (Milan) eu-south-1") EU_SOUTH_1("eu-south-1"),
          @Tag(20) @DisplayMetadata(label = "Europe (Paris) eu-west-3") EU_WEST_3("eu-west-3"),
          @Tag(21) @DisplayMetadata(label = "Europe (Stockholm) eu-north-1") EU_NORTH_1("eu-north-1"),
          @Tag(22) @DisplayMetadata(label = "Middle East (Bahrain) me-south-1") ME_SOUTH_1("me-south-1"),
          @Tag(23) @DisplayMetadata(label = "South America (São Paulo) sa-east-1") SA_EAST_1("sa-east-1"),
          @Tag(24) @DisplayMetadata(label = "AWS GovCloud (US-East) us-gov-east-1") US_GOV_EAST_1("us-gov-east-1"),
          @Tag(25) @DisplayMetadata(label = "AWS GovCloud (US) us-gov-west-1") US_GOV_WEST_1("us-gov-west-1");

the correct region code is: cn-north-1 and cn-northwest-1, and I also found there will have connection issues in China regions. And I have node dive deep on this if this will result the issues.

zorrofox · October 18, 2022, 2:15am

I hive created a pull request to fix it: AWS Glue china regions fix by zorrofox · Pull Request #81 · dremio/dremio-oss · GitHub

Topic		Replies	Views
Add ap-east-1 region for Dremio AWS Edition Marketplace	0	784	May 5, 2021
Unable to execute HTTP request: Connect to sts.us-east-1.amazonaws.com in Dremio Cloud Dremio Cloud	9	6626	August 4, 2022
Glue Data Catalog	2	1003	May 14, 2020
Dremio setup error : Failed to get policy document to validate permissions	8	586	September 26, 2023
Trouble adding Glue Catalog?	5	60	December 5, 2024

I think the dremio-oss Glue endpoint for China regions is not correct

Related topics